[Differential] D12457: Complete INADDR_HASH lock protection

eugen_grosbein.net (Eugene Grosbein) phabric-noreply at FreeBSD.org
Tue Sep 26 11:03:28 UTC 2017


eugen_grosbein.net marked an inline comment as done.
eugen_grosbein.net added inline comments.

INLINE COMMENTS

> mav wrote in in_mcast.c:1383
> Do I miss some other protection means or this and few below places just scream about possible races due to missing interface pointer pulled out of the lock without taking reference?
> 
> I suspect INADDR_TO_IFP KPI is not safe now in general.

Yes, it does. I just want to fix that what's easy to fix to start.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D12457

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-net-list


More information about the freebsd-net mailing list