vmxnet3 driver bug?
Lewis Donzis
lew at perftech.com
Tue Oct 17 14:36:40 UTC 2017
The VMXNET3 driver appears to have a bug that prevents it from correctly reporting when the link goes down.
There are two lines of code that should be deleted in /usr/src/sys/dev/vmware/vmxnet3/if_vmx.c:
@@ -3619,8 +3619,6 @@ vmxnet3_media_status(struct ifnet *ifp, struct ifmediareq *ifmr)
VMXNET3_CORE_LOCK(sc);
if (vmxnet3_link_is_up(sc) != 0)
ifmr->ifm_status |= IFM_ACTIVE;
- else
- ifmr->ifm_status |= IFM_NONE;
VMXNET3_CORE_UNLOCK(sc);
}
IFM_NONE doesn’t belong in the status flags and, coincidentally, is defined with an identical value as IFM_ACTIVE, so it indicates that link is always active.
Thanks,
lew
More information about the freebsd-net
mailing list