[Differential] D10485: Replace dhcp option 150 by 66

[tsoome (Toomas Soome)]

tsoome added a comment.


  In https://reviews.freebsd.org/D10485#219245, @kczekirda wrote:
  
  > @rgrimes 
  >  Please try to boot CURRENT over tftp protocol and without any third part software like iPXE.
  >
  > @tsoome
  >
  > > Note that dhcp servers in real life can offer all the configured data. And well, we can process both 66 and 150 just because that data may be there anyhow.
  >
  > It's not the server side problem, but the client's side. How we can process option 150 if it not exists? I'm sorry, but I'm not able to do this.
  >
  >   tcpdump: listening on br-lan, link-type EN10MB (Ethernet), capture size 65535 bytes
  >   23:39:38.527420 IP (tos 0x0, ttl 20, id 0, offset 0, flags [none], proto UDP (17), length 576)
  >       0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 84:8f:69:f1:00:2d, length 548, xid 0x69f1002d, Flags [Broadcast] (0x8000)
  >   	  Client-Ethernet-Address 84:8f:69:f1:00:2d
  >   	  Vendor-rfc1048 Extensions
  >   	    Magic Cookie 0x63825363
  >   	    DHCP-Message Option 53, length 1: Discover
  >   	    Parameter-Request Option 55, length 36: 
  >   	      Subnet-Mask, Time-Zone, Default-Gateway, Time-Server
  >   	      IEN-Name-Server, Domain-Name-Server, RL, Hostname
  >   	      BS, Domain-Name, SS, RP
  >   	      EP, RSZ, TTL, BR
  >   	      YD, YS, NTP, Vendor-Option
  >   	      Requested-IP, Lease-Time, Server-ID, RN
  >   	      RB, Vendor-Class, TFTP, BF
  >   	      Option 128, Option 129, Option 130, Option 131
  >   	      Option 132, Option 133, Option 134, Option 135
  >   	    MSZ Option 57, length 2: 1260
  >   	    GUID Option 97, length 17: 0.68.69.76.76.67.0.16.50.128.89.185.192.79.87.80.49
  >   	    Client-ID Option 61, length 17: "DELLC^@^P2M-^@YM-9M- at OWP1"
  >   	    ARCH Option 93, length 2: 0
  >   	    NDI Option 94, length 3: 1.2.1
  >   	    Vendor-Class Option 60, length 32: "PXEClient:Arch:00000:UNDI:002001"
  >   	    END Option 255, length 0
  >   	    PAD Option 0, length 0, occurs 181
  >   23:39:39.007131 IP (tos 0x10, ttl 128, id 0, offset 0, flags [none], proto UDP (17), length 342)
  >       192.168.22.1.67 > 255.255.255.255.68: [udp sum ok] BOOTP/DHCP, Reply, length 314, xid 0x69f1002d, Flags [Broadcast] (0x8000)
  >   	  Your-IP 192.168.22.56
  >   	  Server-IP 192.168.22.19
  >   	  Client-Ethernet-Address 84:8f:69:f1:00:2d
  >   	  file "pxeboot"
  >   	  Vendor-rfc1048 Extensions
  >   	    Magic Cookie 0x63825363
  >   	    DHCP-Message Option 53, length 1: Offer
  >   	    Server-ID Option 54, length 4: 192.168.22.1
  >   	    Lease-Time Option 51, length 4: 3600
  >   	    Subnet-Mask Option 1, length 4: 255.255.255.0
  >   	    Default-Gateway Option 3, length 4: 192.168.22.1
  >   	    Domain-Name-Server Option 6, length 8: 8.8.8.8,8.8.4.4
  >   	    Hostname Option 12, length 5: "e6220"
  >   	    RP Option 17, length 15: "192.168.22.19:/"
  >   	    BR Option 28, length 4: 192.168.22.255
  >   	    TFTP Option 66, length 4: "test"
  >   	    END Option 255, length 0
  >
  >
  > If we want to process data from dhcp_try_rfc1048() we have to drop option 150, because it's not exists there.
  >  I like your idea for detecting protocol type.
  
  
  If it does not exist, the its easy;) the better question is, what to do if both 66 and 150 are present and are different;)

REVISION DETAIL
  https://reviews.freebsd.org/D10485

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp, jhb
Cc: rgrimes, garga, ler, asomers