[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

Fri Mar 24 16:03:24 UTC 2017

wblock accepted this revision.
wblock added a comment.
This revision has a positive review.

  One suggestion, but looks good otherwise.  Thank you!

INLINE COMMENTS

> ng_pppoe.4:115
> +.Qq Li 0x ,
> +eg. 
> +.Qq Li 0x6d792d746167

Would prefer "like" or "for example" to exempli gratia here (see `igor -y ng_pppoe.4`), but if you want to stick with that, it should be "e.g.,".  Yes, it's clunky.  In this case, I prefer "like".

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D9270

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: ale, julian, #manpages, mav, #network, adrian, wblock
Cc: wblock, mav, poolroom_gmail.com, mandree, imp, freebsd-net-list