[Differential] D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h

[David_A_Bright_DELL.com (David A. Bright)]

David_A_Bright_DELL.com added a comment.


  Just a couple style nits.

INLINE COMMENTS

> if_var.h:407
>  EVENTHANDLER_DECLARE(ifnet_link_event, ifnet_link_event_handler_t);
> +/* Interface up/ifdown event */
> +#define IFNET_EVENT_UP		0

I would stick with the previous "ifup/ifdown" or go with "Interface up/down". I think "Interface up/ifdown" reads poorly.

> if_var.h:408
> +/* Interface up/ifdown event */
> +#define IFNET_EVENT_UP		0
> +#define IFNET_EVENT_DOWN	1

It would be nice to have the 0/1 values for these two defines line up. In any case, it definitely seems like there is extraneous whitespace between "IFNET_EVENT_UP" and "0".

REVISION DETAIL
  https://reviews.freebsd.org/D9345

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij, royger, glebius, gnn, rwatson
Cc: David_A_Bright_DELL.com, freebsd-net-list