[Differential] D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE

[julian (JulianElischer)]

julian added a comment.


  Considering how much work went into writing this and the fact that we had to get it approved by verizon (or whatever they were called at the time) its amazing that I remember almost nothing about how it works.

INLINE COMMENTS

> ng_pppoe.4:111
> +To set a binary Host-Uniq, it must be encoded as a hexadecimal lowercase
> +string and prefixed with "0x".
>  A session request packet will be broadcasted on the Ethernet.

There are ways to set binary values. though this will do. I f we decide it's limiting, we can improve it.

> ng_pppoe.c:855
>  			 * Store the originator of this message so we can send
>  			 * a success of fail message to them later.
>  			 * Move the session to SINIT.

can you fix the typo here while you are here.. of -> or

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D9270

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: ale, #network, #manpages, julian
Cc: mandree, imp, freebsd-net-list