powerpc.LINT* broken in netmap(4)

[Vincenzo Maffione]

2017-01-13 23:27 GMT+01:00 Ngie Cooper (yaneurabeya) <yaneurabeya at gmail.com>
:

>
> > On Jan 13, 2017, at 02:22, Ngie Cooper (yaneurabeya) <
> yaneurabeya at gmail.com> wrote:
> >
> > Hi,
> >       I spotted these compilation errors on universe12a.freebsd.org for
> both powerpc.LINT and powerpc.LINT64:
> >
> > cc1: warnings being treated as errors
> > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c: In function
> 'generic_set_tx_event':
> > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c:765: warning: the
> address of 'generic_mbuf_destructor' will always evaluate as 'true'
> [-Waddress]
> > --- netmap_generic.o ---
> > *** [netmap_generic.o] Error code 1
> >
> >       I haven’t yet dug into why this only surfaces on powerpc, yet…
>
> (CC -powerpc; BCC +powerpc)
> Hi,
>         sparc64 has the same issue as powerpc*, so I suspect that gcc is
> flagging this as an issue.
> Thanks,
> -Ngie
>
> PS. Sidenote: why was the SET_MBUF_DESTRUCTOR macro added, but not used in
> nm_os_get_mbuf ?
>

Because the destructor is set only on certain mbufs, selected to issue
notifications to netmap applications.
The proper fix is probably to turn the macro to a function, I cannot think
of other solutions.

Cheers,
  Vincenzo

-- 
Vincenzo Maffione