[Bug 200361] net.inet.tcp.hostcache.list is jail information leak

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Jan 2 09:11:45 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200361

--- Comment #5 from Hiren Panchasara <hiren at FreeBSD.org> ---
(In reply to Hiren Panchasara from comment #4)
diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c
index bb2efda..d27f2b5 100644
--- a/sys/netinet/tcp_hostcache.c
+++ b/sys/netinet/tcp_hostcache.c
@@ -69,10 +69,12 @@ __FBSDID("$FreeBSD$");

 #include <sys/param.h>
 #include <sys/systm.h>
+#include <sys/jail.h>
 #include <sys/kernel.h>
 #include <sys/lock.h>
 #include <sys/mutex.h>
 #include <sys/malloc.h>
+#include <sys/proc.h>
 #include <sys/sbuf.h>
 #include <sys/socket.h>
 #include <sys/socketvar.h>
@@ -625,6 +627,9 @@ sysctl_tcp_hc_list(SYSCTL_HANDLER_ARGS)
        char ip6buf[INET6_ADDRSTRLEN];
 #endif

+       if (jailed_without_vnet(curthread->td_ucred) != 0)
+               return (EPERM);
+
        sbuf_new(&sb, NULL, linesize * (V_tcp_hostcache.cache_count + 1),
                SBUF_INCLUDENUL);

Correct version that compiles.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-net mailing list