[Differential] D10485: Replace dhcp option 150 by 66

[rgrimes]

rgrimes added inline comments.

INLINE COMMENTS

> bootp.c:443
> +		if (tag == TAG_TFTP_SERVER_NAME) {
> +			val = strsep(&cp, VEND_INFO_END);
> +			if ((ipaddr = inet_addr(val)) != INADDR_NONE)

You marked this as done but it still only accepts a dotted quad, if we cant process a hostname here maybe that is why Bapt used option 150?   As a minimum add a comment saying there is a known bug here with not processing a hostname, maybe /* XXX Should accept hostname as well as dotted quad */

> bootp.h:99
> +
> +#define VEND_INFO_END		0xff /* End option in RFC2132  */
>  

Good catch, this also makes it match all the options before it in style of value with the cast.

REVISION DETAIL
  https://reviews.freebsd.org/D10485

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp
Cc: rgrimes, garga, ler, asomers