[Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211219

--- Comment #18 from Franco Fichtner <franco at opnsense.org> ---
The second line in the if statement still differs in the way introduced by the
original commit causing the regression:

Original Intel driver and requested in this this PR/attached commit:

ims_mask |= EM_MSIX_MASK;

Current state on all branches:

ims_mask |= adapter->ims;

In our conversations you asked me which of the two lines were needed, because
the chip documentation wasn't clear.

The testing result for a good result (for two distinct devices I have) was:

if (hw->mac.type == e1000_82574) {
    E1000_WRITE_REG(hw, EM_EIAC, adapter->ims);
} 

The current FreeBSD state was changed to read this:

if (hw->mac.type == e1000_82574) {
    E1000_WRITE_REG(hw, EM_EIAC, adapter->ims);
    ims_mask |= adapter->ims;
}

Which still differs from the good tested result or the original Intel state.

Either the second line should be dropped or changed to how it reads in the
Intel driver.


Cheers,
Franco

-- 
You are receiving this mail because:
You are the assignee for the bug.