Int overflow in dhclient(1)

Michael McConville mmcco at mykolab.com
Tue Mar 15 02:05:11 UTC 2016


I sent this a few weeks ago, but it never got applied:

https://marc.info/?l=freebsd-net&m=145392057613453&w=2

Here's my explanation for the same fix in OpenBSD:

https://marc.info/?l=openbsd-tech&m=145377854103866&w=2

Thanks for your time,
Michael


Index: sbin/dhclient/dhclient.c
===================================================================
--- sbin/dhclient/dhclient.c	(revision 296886)
+++ sbin/dhclient/dhclient.c	(working copy)
@@ -138,7 +138,7 @@
 findproto(char *cp, int n)
 {
 	struct sockaddr *sa;
-	int i;
+	unsigned int i;
 
 	if (n == 0)
 		return -1;


More information about the freebsd-net mailing list