[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

[sepherosa_gmail.com (Sepherosa Ziehau)]

sepherosa_gmail.com added inline comments.

INLINE COMMENTS
  sys/netinet/tcp_lro.h:94 My intention here is too keep the size of lro_ctrl unchanged on amd64 (I think there is an implicit 4 bytes padding after lro_mbuf_max :).  But I am fine to change them into unsigned int.
  
  Does anyone know any drawbacks to change these two fields into unsigned int?  If not, I would change them into unsigned int after Chinese New Year :)

REVISION DETAIL
  https://reviews.freebsd.org/D5185

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, hselasky, np, transport, gallatin, adrian, network
Cc: freebsd-virtualization-list, freebsd-net-list