[Differential] D8904: inet: Fix routing issue by calling if_up()

hrs (Hiroki Sato) phabric-noreply at FreeBSD.org
Mon Dec 26 07:43:37 UTC 2016


hrs added a comment.


  The cause is that the prefix route was removed by in_scrubprefix() in the PRC_IFDOWN handler and never reinstalled upon PRC_IFUP because the reinstallation  is done only for ifa passed to SIOCAIFADDR.  Just calling if_up(ifp) looks too heavy to me because it causes extra pr_ctlinput() calls of each protocol, not only inetdomain, in order to recover the routes.  What do you think about adding reinstalltion of the prefix routes in the protocol specific PRC_IFUP handler instead?

REVISION DETAIL
  https://reviews.freebsd.org/D8904

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, adrian, bz, gnn, hiren, glebius, rwatson, karels
Cc: hrs, freebsd-net-list


More information about the freebsd-net mailing list