[Differential] D6137: tcp/lro: Refactor the free/active list operation.

Thu Apr 28 15:19:03 UTC 2016

gallatin added a comment.

  The tcp_lro_entry_get() abstraction adds an extra compare to the critical path (the compare against NULL in the function itself, in addition to the same compare in the main routine).  At least it does at the C level.   Have you verified that the compiler is smart enough to continue to use a single compare?

  If this adds an extra compare to the actual executed code, then I object.

REVISION DETAIL
  https://reviews.freebsd.org/D6137

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, transport, rrs, adrian, delphij, glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, gallatin
Cc: freebsd-net-list