[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

[sepherosa_gmail.com (Sepherosa Ziehau)]

sepherosa_gmail.com added inline comments.

INLINE COMMENTS
  sys/netinet/tcp_output.c:1551 It's what I am testing w/, since I need non-INVARIANT kernel to generate enough traffic to make ENOBUFS happen.
  
  We can change it into KASSERT, however, I am wondering should we just use "if (__predict_false(...)) panic" here?  Missing timeout here can obviously causing issues for data/SYN/FIN.
  
  I will wrap this code segment into a macro (change it into KASSERT is fine w/ me) after more testing.
  
  I think the code segment is fine now; we just need to inverse the logic, if we choose to use KASSERT.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, lstewart, hiren, jtl, transport
Cc: gnn, mike-karels.net, jtl