[Differential] [Commented On] D5872: tcp: Don't prematurely drop receiving-only connections

[sepherosa_gmail.com (Sepherosa Ziehau)]

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D5872#127063, @jtl wrote:
  
  > Doesn't tp->t_rxtshift get updated on a successful send? If not, I think that is what we should be fixing.
  >
  > Personally, I think a connection should drop if we aren't able to send any ACKs for 350 seconds.
  
  
  It's t_shift >= 12 killing the connection, since no one actually stops the timer/performs RTT update for ACK if ENOBUFS happens on a receiving only connections.  So intermittent (not continuous) failures to transmit ACK due to ENOBUFS will kill a long living receiving only connection eventually.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, lstewart, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, transport, jtl, hiren
Cc: mike-karels.net, jtl