kern.ipc.sockbuf limits: anyone mind if I commit this?

[Alfred Perlstein]

On 11/10/15 3:13 PM, Adrian Chadd wrote:
> hiya,
>
> there's a PR with a patch:
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
>
> https://github.com/sparrc/freebsd/commit/157f90c55d1d54d33f41c6f7517de1a9c5f5e229
>
> Does anyone know why setting the limits isn't as simple as this patch?
>
> Does anyone mind if I just commit this?
>
Don't mind too heavily, however the old behavior is bad and confusing 
however at least it stops you, however the new behavior will be odd and 
incorrect without warning.

More succinctly: Silently "accepting" but actually changing the value 
passed in seems wrong.

It would seem the reason for the calculation is to actually limit the 
number of bytes of mbufs (not just data) to the max value?  Is that true?

Maybe it makes sense to export sb_max_adj via sysctl and allow setting 
of it instead?  Having silent clipping seems worse than an error.

-Alfred