[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

rstone (Ryan Stone) phabric-noreply at FreeBSD.org
Mon Mar 2 00:02:08 UTC 2015


rstone added inline comments.

INLINE COMMENTS
  sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?)
  sys/net/if_lagg.c:1773 style(9): put brackets around the return value:
  
  return (0);
  sys/net/if_lagg.c:1811 I find the flow control here a bit confusing (my first read through, I thought that err2 could be used unitinialized).  Given that you have a continue in the if block, I would find it clearer to not have an else here

REVISION DETAIL
  https://reviews.freebsd.org/D1986

To: rpokala-panasas.com, rstone
Cc: ae, freebsd-net


More information about the freebsd-net mailing list