[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

[hselasky (Hans Petter Selasky)]

hselasky added a comment.

Did you upload the correct patch?

INLINE COMMENTS
  sys/kern/kern_timeout.c:674 I don't mean inside the if (c_lock != NULL) { }
  There should be an else case after it.
  if (c_lock != NULL) {
   ... 
  } else {
     /* The callout cannot be stopped now */
    cc_exec_cancel(cc, direct) = true;  /* XXX this piece is missing */
  }
  
  Because else callout_stop() will return (1) when cancel() == false, which is a lie. It cannot stop the MPSAFE callout in this case and has to let it run ???

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky
Cc: neel, erj, freebsd-net