[Differential] [Request, 20 lines] D1699: sfxge: Remove extra cache-line alignment and reorder sfxge_evq_t
arybchik (Andrew Rybchenko)
phabric-noreply at FreeBSD.org
Wed Jan 28 08:31:22 UTC 2015
arybchik created this revision.
arybchik added a reviewer: gnn.
arybchik added a subscriber: freebsd-net.
REVISION SUMMARY
Remove the first member alignment to cacheline since it is nop.
Use __aligned() for the whole structure to make sure that the structure
size is cacheline aligned.
Remove lock alignment to make the structure smaller and fit all members
used on event queue processing into one cacheline (128 bytes) on x86-64.
The lock is obtained as well from different context when event queue
statistics are retrived from sysctl context, but it is infrequent.
Reorder members to avoid padding and go in usage order on event
processing.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1699
AFFECTED FILES
sys/dev/sfxge/sfxge.h
To: arybchik, gnn
Cc: freebsd-net
More information about the freebsd-net
mailing list