[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

[hiren (hiren panchasara)]

hiren added a comment.

@rrs:
Looks like we've come full circle back to the very first crash reported. We are on stable10 with all relevant fixes. 

Sanitized panic #4

  
    Dump header from device /dev/da0s1b
    Architecture: amd64
    Architecture Version: 2
    Dump Length: 6764437504B (6451 MB)
    Blocksize: 512
    Dumptime: Mon Feb 16 02:54:11 2015
    Hostname: xxxxxxxxxxxxxxx
    Magic: FreeBSD Kernel Dump
    Version String: FreeBSD 10.1-STABLE-llnw12 #0: Fri Feb 13 02:22:48 MST 2015
      jason at xxxxxxxxxxxxx:/usr/obj/usr/src/sys/SIXFOUR
    Panic String: spin lock held too long
    Dump Parity: 1861214463
    Bounds: 0
    Dump Status: good
  
  Backtrace:
  Reading symbols from /boot/kernel/cc_cubic.ko.symbols...done.
  Loaded symbols for /boot/kernel/cc_cubic.ko.symbols
  Reading symbols from /boot/kernel/cc_cdg.ko.symbols...done.
  Loaded symbols for /boot/kernel/cc_cdg.ko.symbols
  Reading symbols from /boot/kernel/h_ertt.ko.symbols...done.
  Loaded symbols for /boot/kernel/h_ertt.ko.symbols
  Reading symbols from /boot/kernel/ftcp.ko...done.
  Loaded symbols for /boot/kernel/ftcp.ko
  #0  doadump (textdump=1) at pcpu.h:219
  	in pcpu.h
  (kgdb) #0  doadump (textdump=1) at pcpu.h:219
  #1  0xffffffff80749c17 in kern_reboot (howto=260)
      at /usr/src/sys/kern/kern_shutdown.c:452
  #2  0xffffffff80749ff4 in panic (fmt=<value optimized out>)
      at /usr/src/sys/kern/kern_shutdown.c:759
  #3  0xffffffff80735683 in _mtx_lock_spin_cookie (c=<value optimized out>, 
      tid=<value optimized out>, opts=<value optimized out>, 
      file=<value optimized out>, line=<value optimized out>)
      at /usr/src/sys/kern/kern_mutex.c:561
  #4  0xffffffff80760064 in callout_lock (c=0xfffff80870266e80)
      at /usr/src/sys/kern/kern_timeout.c:530
  #5  0xffffffff8075fc62 in callout_reset_sbt_on (c=0xfffff80870266e80, 
      sbt=<value optimized out>, precision=<value optimized out>, 
      ftn=0xffffffff808bcfe0 <tcp_timer_rexmt>, arg=0xfffff80870266c00, 
      cpu=<value optimized out>, flags=<value optimized out>)
      at /usr/src/sys/kern/kern_timeout.c:975
  #6  0xffffffff808bd807 in tcp_timer_activate (tp=0x0, 
      timer_type=<value optimized out>, delta=<value optimized out>)
      at /usr/src/sys/netinet/tcp_timer.c:883
  #7  0xffffffff808b3ce0 in tcp_output (tp=0xfffff80870266c00)
      at /usr/src/sys/netinet/tcp_output.c:1579
  #8  0xffffffff808bfa41 in tcp_usr_send (so=<value optimized out>, 
      flags=<value optimized out>, m=<value optimized out>, 
      nam=<value optimized out>, control=<value optimized out>, 
      td=<value optimized out>) at /usr/src/sys/netinet/tcp_usrreq.c:887
  #9  0xffffffff807c2535 in sosend_generic (so=0xfffff80678731000, addr=0x0, 
      uio=0xfffffe2021072960, top=<value optimized out>, 
      control=<value optimized out>, flags=<value optimized out>, td=0x143)
      at /usr/src/sys/kern/uipc_socket.c:1284
  #10 0xffffffff807a3fc3 in soo_write (fp=<value optimized out>, 
      uio=0xfffffe2021072960, active_cred=<value optimized out>, 
      flags=<value optimized out>, td=<value optimized out>)
      at /usr/src/sys/kern/sys_socket.c:103
  #11 0xffffffff8079cb47 in dofilewrite (td=0xfffff8011c9c7920, fd=323, 
      fp=0xfffff804c4c17870, auio=0xfffffe2021072960, 
      offset=<value optimized out>, flags=0) at file.h:304
  #12 0xffffffff8079c878 in kern_writev (td=0xfffff8011c9c7920, fd=323, 
      auio=0xfffffe2021072960) at /usr/src/sys/kern/sys_generic.c:481
  #13 0xffffffff8079c803 in sys_write (td=<value optimized out>, 
      uap=<value optimized out>) at /usr/src/sys/kern/sys_generic.c:396
  #14 0xffffffff80b059ca in amd64_syscall (td=0xfffff8011c9c7920, traced=0)
      at subr_syscall.c:134
  #15 0xffffffff80aeae3b in Xfast_syscall ()
      at /usr/src/sys/amd64/amd64/exception.S:396
  #16 0x0000000801640b8a in ?? ()
  Current language:  auto; currently minimal
  (kgdb)

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky
Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net