[Bug 189219] [dummynet] [patch] using dummynet on sparc64 and configuring a pipe is an insta-panic

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Dec 3 01:00:21 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=189219

--- Comment #6 from Marius Strobl <marius at FreeBSD.org> ---
(In reply to Michael Moll from comment #2)

That patch is overly complicated for solving the unaligned access triggered by
config_link(); it's way simpler to just fix do_config() to properly align
dn_link before passing it on in the first place. Moreover, the latter also is
the actual culprit here as do_config() casts a random chunk of memory to a
struct dn_link pointer. Note, though, that the config_link() triggered
unaligned access is only one instance of dummynet(4) misaligning dn_link. The
following is a complete fix in that regard:
http://people.freebsd.org/~marius/dummynet_unfuck_dn_link.diff

However, the same incorrect patterns are used for virtually all of dn_<foo> and
additionally in some other stuff like flow ID related functions. So someone
still needs to sit down and go through the entirety of ip_dummynet.c, fixing
all other unaligned accesses.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-net mailing list