Choice of private ioctl approach

[John Baldwin]

On Monday, September 29, 2014 8:36:22 am Andrew Rybchenko wrote:
> Hello,
> 
> we need to add private ioctl to the driver sfxge(4) to make FW update,
> do internal diagnostics commands etc.
> We see at least two approaches in other drivers:
>   1. SIOCGPRIVATE_0/ SIOCGPRIVATE_1 on net device
>   2. dedicated char device with its own ioctl's
> 
> Is there any recommendations on which way is preferred?

I would be inclined towards 2).  It is more flexible if you need to add more 
custom ioctls in the future.

-- 
John Baldwin