[Bug 194453] [dummynet] pipe config bw parameter is limited to 2Gbits per second

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194453

--- Comment #4 from boba at boba.name ---
(In reply to Hiren Panchasara from comment #2)
> (In reply to boba from comment #0)
> > It's impossible to create "pipe" with bandwidth higher than 2Gbits per
> > second. Possible due to "signed" type of variable.
> > 
> > # ipfw pipe 1 config bw 2700mbit/s
> > ipfw: bandwidth too large
> 
> I think you are right that its overflowing because of "signed" type.
> 
> A simple change like this may fix the problem:
> 
> Index: dummynet.c
> ===================================================================
> --- dummynet.c  (revision 270969)
> +++ dummynet.c  (working copy)
> @@ -546,7 +546,7 @@
>                 if_name[namelen] = '\0';
>                 *bandwidth = 0;
>         } else {        /* read bandwidth value */
> -               int bw;
> +               uint32_t bw;
>                 char *end = NULL;
>  
>                 bw = strtoul(arg, &end, 0);

This patch will not work at all because of following check few lines after it:

                if (bw < 0)
                        errx(EX_DATAERR, "bandwidth too large");

-- 
You are receiving this mail because:
You are the assignee for the bug.