Patch: Should netmap prototypes use const where possible?

Mark Delany c2h at romeo.emu.st
Fri Mar 21 14:48:41 UTC 2014


Subject line says it all. I don't know what the convention is, but I
presume everything should be declared const whenever possible, thus
the appended patch.

Mark.
-------------- next part --------------
*** /usr/include/net/netmap_user.h	Sun Mar 16 12:01:36 2014
--- /tmp/./netmap_user.h	Fri Mar 21 07:39:16 2014
***************
*** 97,103 ****
  
  
  static inline uint32_t
! nm_ring_next(struct netmap_ring *r, uint32_t i)
  {
  	return ( unlikely(i + 1 == r->num_slots) ? 0 : i + 1);
  }
--- 97,103 ----
  
  
  static inline uint32_t
! nm_ring_next(const struct netmap_ring *r, uint32_t i)
  {
  	return ( unlikely(i + 1 == r->num_slots) ? 0 : i + 1);
  }
***************
*** 108,121 ****
   * When everything is complete ring->head = ring->tail + 1 (modulo ring size)
   */
  static inline int
! nm_tx_pending(struct netmap_ring *r)
  {
  	return nm_ring_next(r, r->tail) != r->head;
  }
  
  
  static inline uint32_t
! nm_ring_space(struct netmap_ring *ring)
  {
          int ret = ring->tail - ring->cur;
          if (ret < 0)
--- 108,121 ----
   * When everything is complete ring->head = ring->tail + 1 (modulo ring size)
   */
  static inline int
! nm_tx_pending(const struct netmap_ring *r)
  {
  	return nm_ring_next(r, r->tail) != r->head;
  }
  
  
  static inline uint32_t
! nm_ring_space(const struct netmap_ring *ring)
  {
          int ret = ring->tail - ring->cur;
          if (ret < 0)


More information about the freebsd-net mailing list