Multipath TCP for FreeBSD v0.4

[Nigel Williams]

Just a quick note for anyone else that might be trying out the patch...

>
> and I've built the whole system on both nodes without WITNESS and other debug-
> ging functionalities:
> ===============================================================================
> Index: /usr/src/sys/amd64/conf/GENERIC
> ===================================================================
> --- /usr/src/sys/amd64/conf/GENERIC     (revision 265307)
> +++ /usr/src/sys/amd64/conf/GENERIC     (working copy)
> @@ -76,14 +76,14 @@
>   options        KDB                     # Enable kernel debugger support.
>   options        KDB_TRACE               # Print a stack trace for a panic.
>   # For full debugger support use (turn off in stable branch):
> -options        DDB                     # Support DDB.
> -options        GDB                     # Support remote GDB.
> -options        DEADLKRES               # Enable the deadlock resolver
> -options        INVARIANTS              # Enable calls of extra sanity checking
> -options        INVARIANT_SUPPORT       # Extra sanity checks of internal structures, required by INVARIANTS
> -options        WITNESS                 # Enable checks to detect deadlocks and cycles
> -options        WITNESS_SKIPSPIN        # Don't run witness on spinlocks for speed
> -options        MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
> +#options       DDB                     # Support DDB.
> +#options       GDB                     # Support remote GDB.
> +#options       DEADLKRES               # Enable the deadlock resolver
> +#options       INVARIANTS              # Enable calls of extra sanity checking
> +#options       INVARIANT_SUPPORT       # Extra sanity checks of internal structures, required by INVARIANTS
> +#options       WITNESS                 # Enable checks to detect deadlocks and cycles
> +#options       WITNESS_SKIPSPIN        # Don't run witness on spinlocks for speed
> +#options       MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
>
>   # Make an SMP-capable kernel by default
>   options        SMP                     # Symmetric MultiProcessor Kernel
> ===============================================================================

I'd recommend leaving debugging options on (at minimum INVARIANTS and 
INVARIANT_SUPPORT). This will slow network performance but will allow a 
number of assertions to run that can make it a little easier to debug 
some issues.

cheers,
nigel