(removing mbuf flowid setup in flowtable.c)

Warner Losh imp at bsdimp.com
Thu Jan 30 18:49:12 UTC 2014


On Jan 30, 2014, at 11:40 AM, Adrian Chadd wrote:

> On 30 January 2014 07:18, Adrian Chadd <adrian at freebsd.org> wrote:
>> Hi,
>> 
>> I'd like to disable the code in flowtable.c that assigns the mbuf flowid.
>> 
>> I'd like to ensure that any mbuf flowid that's set is (eventually)
>> going to be consistently toeplitz in the future (to match what NICs
>> are doing on the RX side) and this may cause the flowid to be set to
>> something completely different.
>> 
>> I've only done some light production testing with this so far, to no
>> visible ill effects.
>> 
>> What do people think?
> 
> Someone pointed out privately that doing this would mean that UDP
> flows without flow ids would suddenly not have flowids any longer and
> thus wouldn't use multiple output queues.
> 
> So, I'll leave this alone for now until I can import the toeplitz hash
> code into -HEAD and add an option to tag outbound udp frames with this
> particular flowid hash.

toeplitz is a funky kind of matrix, according to google. What does that have to do with mbufs? :)

Warner



More information about the freebsd-net mailing list