ip6opt.c

[Sascha Wildner]

On Mon, 03 Feb 2014 21:26:25 +0100, Hiroki Sato <hrs at freebsd.org> wrote:

> Eitan Adler <lists at eitanadler.com> wrote
>   in  
> <CAF6rxgmQMXKDMETRPRE-QkQwGS3vgZxQRFKoe6d3_BycQOouYw at mail.gmail.com>:
>
> li> Hi all,
> li>
> li> DragonFly recently committed the following change and it seems that  
> it
> li> applies to us as well.
> li>
> li>  
> http://gitweb.dragonflybsd.org/dragonfly.git/blobdiff/5764e12516158974fac10d50dbd2df76ce1ab007..98651c6e0e1c3b7a6b8650b55b473fcc745a22b7:/lib/libc/net/ip6opt.c
> li>
> li> Should I commit it?
>
>  Just out of curiousity, what is the problem with returning -1 when
>  (extbuf == NULL) && (extlen % 8) != 0?

I read the RFC as saying that the extlen check should be performed in the  
extbuf != NULL case, not when it is NULL. No real problem, really.

Sascha