[Differential] [Request, 70 lines] D1309: VIMAGE PF fixes #1

[rodrigc (Craig Rodrigues)]

rodrigc created this revision.
rodrigc added reviewers: bz, glebius.
rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization.

REVISION SUMMARY
  Merge: r258322 from projects/pf branch
  
  - Split functions that initialize various pf parts into their vimage
    parts and global parts.
  - Since global parts appeared to be only mutex initializations, just
    abandon them and use MTX_SYSINIT() instead.
  - Kill my incorrect VNET_FOREACH() iterator and instead use correct
    approach with VNET_SYSINIT().
      
  Submitted by:   glebius, Nikos Vassiliadis <nvass gmx.com>
  Reviewed by:    trociny

TEST PLAN
  - compiled CURRENT kernel with this patch
  - booted
  - created VNET jail
  - started PF in the jail
  
  Eliminated some crashes  such as PR 194515

REVISION DETAIL
  https://reviews.freebsd.org/D1309

AFFECTED FILES
  sys/net/pfvar.h
  sys/netpfil/pf/pf.c
  sys/netpfil/pf/pf_if.c
  sys/netpfil/pf/pf_ioctl.c
  sys/netpfil/pf/pf_norm.c

To: rodrigc, bz, glebius
Cc: freebsd-virtualization, freebsd-pf, freebsd-net