Defaults for if_capenable and detecting user initiated changes

[Justin T. Gibbs]

Hi net,

I’m reviewing a patch from Roger Pau Monné for the Xen netfront driver.  The goal of the change is to avoid disturbing the user’s settings for the interface just because the backend device has changed or the connection to the backend was reset.  I’ve attached the latest version of the patch.

The current patch leaves the interface settings alone if they can be supported by the newly attached backend.  What would be ideal is to enable capabilities that default to being enabled if they were not explicitly disabled by the user and can be supported by the new backend.  Unfortunately, I don’t think the if_capenable and if_capabilities fields are descriptive enough to deal with an interface whose capabilities can change at runtime.  Just as can be done with link speed, some of these settings need to allow an “auto/default” setting in addition to on or off.  This would allow the user to explicitly disable a capability if needed, but generally allow the system to chose the most optimal settings when they are supported.  Would this be difficult to add?

Thanks,
Justin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xen-netfront-keep-xn-options-on-suspend-resume.patch
Type: application/octet-stream
Size: 2760 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20131127/5befa8b9/attachment.obj>