OCE driver patches

Duvvuru,Venkat Kumar VenkatKumar.Duvvuru at Emulex.Com
Wed Mar 6 07:01:41 UTC 2013


Hi Josh,
I'm attaching a .tgz file of the patches (oce0.patch to oce24.patch, Please make sure that you apply them in the same order) that I told you about for the Emulex's OCE driver.
I had opened a PR for the same, However .tgz files are not allowed as attachments to the problem report, So I just renamed .tgz file to .txt for uploading.
However I have not gotten any email notification on that problem report, could be because of the attachment problem I guess. 
Please let me know if I could open a PR without any attachment and send you that PR number.
Also  there is a notification about freebsd 8.4 code freeze by March 8. It would be nice if we could get these patches in before the code freeze on 8.4 as well.

Pls suggest.

Thanks,
Venkat.

-----Original Message-----
From: Josh Paetzel [mailto:josh at tcbug.org] 
Sent: Friday, March 01, 2013 8:08 PM
To: Duvvuru,Venkat Kumar
Cc: freebsd-net at freebsd.org
Subject: Re: OCE driver patches

On Mar 1, 2013, at 5:36 AM, "Duvvuru,Venkat Kumar" <VenkatKumar.Duvvuru at Emulex.Com> wrote:

> Hi Josh,
> I have a bunch of patches (~25 in number) to submit. Please let me know the process to submit them.
> Do I just attach them in a single email or open pr's for each of them??
> Pls suggest.
> 
> /Venkat
> 

Venkat,

I think it depends on how you want them committed to FreeBSD. 

If the patches are atomic changes that should be kept atomic in the FreeBSD source tree then I'll commit them seperately. This is a tad time consuming as I test them atomically before committing them.  If they can be committed in one go then I can just apply them all, test the end result, and commit that.

One PR with the patches attached and a note saying these can all go in in one go is appropriate in the latter case, the former would be best served by seperate PRs.

Thanks,

Josh Paetzel


More information about the freebsd-net mailing list