[CFT] if_transmit method for lagg(4)

Andrew Thompson thompsa at FreeBSD.org
Thu Sep 20 08:54:52 UTC 2012


On 20 September 2012 20:48, Gleb Smirnoff <glebius at freebsd.org> wrote:
>   Hi!
>
> On Thu, Sep 20, 2012 at 08:37:19PM +1200, Andrew Thompson wrote:
> A> >   Yet another patch to test. Was suprising to me that lagg(4), which
> A> > aims at high-performance, still utilizes if_start.
> A> >
> A> >   Attached is patch that converts lagg(4) to use if_transmit. I'd
> A> > appreciate if someone who do use lagg(4) tests the patch. If anyone
> A> > benchmarks lagg(4) with and w/o patch that will be most appreciated.
> A>
> A> Sean Bruno has already tested this patch at Yahoo, I have just been
> A> delayed in committing it. There are just a few small differences so we
> A> can commit one or merge.
>
> Also fabient@ replied to me in private with this patch :)
>
> Hmm, I've missed stats update. I have merge statistics updates from your patch
> to mine and here it is attached.

Looks good, please commit.

There is just a stray `i` here

+static int     lagg_transmit(struct ifnet *i, struct mbuf *);


Andrew


More information about the freebsd-net mailing list