STP id selection

Adrian Chadd adrian at freebsd.org
Sun Jan 22 07:29:19 UTC 2012


On 21 January 2012 05:37, Nikos Vassiliadis <nvass at gmx.com> wrote:

> Hi,
>
> The current code in bridgestp.c finds the lower MAC address from all
> available ethernets and uses it as the STP id. This is problematic when
> more than one STP bridges participate in the same STP domain because
> more than one bridges will use the same id. A similar fix was applied
> to the OpenBSD version of the code[1]. Could you review the attached
> patch?
>
> 1.http://www.openbsd.org/cgi-**bin/cvsweb/src/sys/net/**
> bridgestp.c?rev=1.33<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/bridgestp.c?rev=1.33>
>
> Thanks, Nikos
>
>
.. that sounds sensible enough. Sure, please create a PR and then tell me
what the ID is.

I keep finding myself knee deep in the bridge code so this is something I
can test out locally.


Adrian


More information about the freebsd-net mailing list