LOR in rtsock/ifnet

[Hiroki Sato]

Mateusz Guzik <mjguzik at gmail.com> wrote
  in <20121201223049.GA12120 at dft-labs.eu>:

mj> On Sun, Dec 02, 2012 at 06:54:36AM +0900, Hiroki Sato wrote:
mj> > Hiroki Sato <hrs at freebsd.org> wrote
mj> >   in <20121201.225004.2232262673795057435.hrs at allbsd.org>:
mj> >
mj> > hr> Mateusz Guzik <mjguzik at gmail.com> wrote
mj> > hr>   in <20121201133609.GA5450 at dft-labs.eu>:
mj> > hr>
mj> > hr> mj> On Fri, Nov 30, 2012 at 11:16:25PM -0800, Adrian Chadd wrote:
mj> > hr> mj> > Mateusz: are you sure it's that commit?
mj> > hr> mj> >
mj> > hr> mj>
mj> > hr> mj> Yes, I double-checked right now.
mj> > hr> mj>
mj> > hr> mj> > I still get this in -HEAD:
mj> > hr> mj> >
mj> > hr> mj>
mj> > hr> mj> Maybe I expressed myself incorrectly, I meant to say that LOR started
mj> > hr> mj> showing up since r243187.
mj> > hr> mj>
mj> > hr> mj> The code is still in head and no fixes were comitted (that I know of at
mj> > hr> mj> least), so I guess that you seeing this LOR on head is expected. :)
mj> > hr>
mj> > hr>  Thanks for the info.  I am investigating this now.
mj> >
mj> >  Can anyone test the attached patch and let me know if the LOR
mj> >  persists or not?
mj> >
mj>
mj> I got the following build failure:
mj> /srv/repos/freebsd/sys/netinet6/in6_cksum.c:69:22: error: sys/vnet.h: No
mj> such file or directory
mj> In file included from /srv/repos/freebsd/sys/netinet6/in6_cksum.c:72:
mj> /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: error: expected
mj> declaration specifiers or '...' before 'deembed_scopeid'
mj> cc1: warnings being treated as errors
mj> /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: data
mj> definition has no type or storage class
mj> /srv/repos/freebsd/sys/netinet6/scope6_var.h:45: warning: type defaults
mj> to 'int' in declaration of 'VNET_DECLARE'

 Oops, sorry.  The attached one should work.  The difference is only
 s|sys/vnet.h|net/vnet| as you also pointed out.

mj> However after changing sys/vnet.h to net/vnet.h the kernel compiled fine
mj> and LOR is gone.

 Thank you!  I am double-checking if there is some negative impact by
 this change.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scope6_lorfix_20121201-2.diff
Type: text/x-patch
Size: 6544 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20121202/25ecf265/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20121202/25ecf265/attachment.sig>