[RFC] Better document net.inet6 sysctls and prune dead sysctls (fwd)

[Garrett Cooper]

On Sat, Dec 1, 2012 at 1:55 AM, Bruce Evans <brde at optusnet.com.au> wrote:
> On Fri, 30 Nov 2012, Garrett Cooper wrote:
>
>> On Fri, 30 Nov 2012, Garrett Cooper wrote:
>
> I got the previous one but was busy.  This one seems to only add freebsd-net
> to the Cc list
>
>>>> It would be good to fix the style bugs when changing lots.
>>>> ...
>>>
>>>         Is this better? I tried to be consistent about using v6 properly
>>> when dealing with protocols in order to match what the IETF did and I
>>> believe I properly integrated in your comments.
>
>
> I'm (almost) happy with this.  Noticed a couple more details.  We're
> stuck with sysctls misspelled by name (without a v)...
>
>>> Index: sys/netinet6/in6_proto.c
>>> ===================================================================
>>> --- sys/netinet6/in6_proto.c    (revision 243557)
>>> +++ sys/netinet6/in6_proto.c    (working copy)
>>> ...
>>>
>>> @@ -382,9 +382,9 @@
>>>  */
>>> #ifndef IPV6FORWARDING
>
> Stray tab here.

Fixed.

>>> #ifdef GATEWAY6
>
> ... and options spelled without a V.

"Fixing" this will break backwards compatibility -_-. Trying to avoid
changing interfaces/#defines.

>>> ...
>>>
>>> @@ -443,13 +441,12 @@
>>>
>>> /* ICMPV6 parameters */
>>> VNET_DEFINE(int, icmp6_rediraccept) = 1;/* accept and process redirects
>>> */
>>> -VNET_DEFINE(int, icmp6_redirtimeout) = 10 * 60;        /* 10 minutes */
>
> Lost this?

This is intentional. This and ip6_rr_prune need to be pruned because
they're unused in the kernel proper.

...

>>> +SYSCTL_NODE(_net_inet6,        IPPROTO_SCTP,   sctp6,  CTLFLAG_RW, 0,
>>> "SCTPv6");
>>> #endif
>>> #ifdef IPSEC
>>> SYSCTL_NODE(_net_inet6, IPPROTO_ESP,    ipsec6, CTLFLAG_RW, 0, "IPSEC6");
>
> I don't like this fancy formatting.  It is hard to maintain, and it is only
> possible to line up all the fields and fit on 1 line when all are short.
> Some mailer already mangled the lines by splitting them and quoting the
> split.

alpine with ^j and gmail probably again (I really need to fix that or
get a less "intelligent" mailer) :/...

> Descriptions like this that used to less than echo the leaf of the
> sysctl name are less than useful.  They seem to be bug for bug
> compatible with ipv4, however:  net.inet.ip is now described as IP (no
> v or 4 in sight).  net.inet6.ip6 is now described as IP6.  I also
> don't like duplicating the 6 at every lower level in name.

I'll just pull the descriptions because it's useless bloat in the
kernel in text form.

>>> ...
>>> SYSCTL_VNET_INT(_net_inet6_ip6, IPV6CTL_V6ONLY, v6only, CTLFLAG_RW,
>
> Stray tab before CTLFLAG* (left over from the fancy formatting?).

I think so. Either way, I quashed what was there :).

>>> -       &VNET_NAME(ip6_v6only), 0, "");
>>> +    &VNET_NAME(ip6_v6only), 0,
>>> +    "Allow IPv4-mapped ip6 addresses per RFC 3493");

Thanks again!
-Garrett