Replace bcopy() to update ether_addr
Warner Losh
imp at bsdimp.com
Wed Aug 22 13:26:41 UTC 2012
On Aug 22, 2012, at 6:02 AM, John Baldwin wrote:
> On Tuesday, August 21, 2012 12:34:42 pm Adrian Chadd wrote:
>> Hi,
>>
>> What about just creating an ETHER_ADDR_COPY(dst, src) and putting that
>> in a relevant include file, then hide the ugliness there?
>>
>> The same benefits will likely appear when copying wifi MAC addresses
>> to/from headers.
>>
>> Thanks, I'm glad someone noticed this.
>
> I doubt we even _need_ the ugliness. We should just use *dst = *src
> unless there is a compelling reason not to.
Agreed. We should do that, and then check the generated code to be sure there isn't a compelling reason there :)
Warner
More information about the freebsd-net
mailing list