ether_demux does not handle frames with embedded vlan tags

[Juli Mallett]

On Wed, Oct 19, 2011 at 07:36, Ryan Stone <rysto32 at gmail.com> wrote:
> 2011/10/19  <rozhuk.im at gmail.com>:
>> This may be a wrong configuration or QinQ: packet may have M_VLAN tag is
>> set and still vlan-tagged (ether_type = VLAN)
>
> It is not QinQ in my case.  The interface that the upper hook exports
> is that you send it a valid ethernet frame and it passes that frame up
> the stack.  A vlan-tagged frame is a valid frame so I don't see why it
> should not be handled correctly.

Why should the requirements for the Netgraph path be any different to
the non-Netgraph path?  If drivers must ensure that frames that reach
ether_demux have had their VLAN tags stripped, so should Netgraph
things that act like drivers.  So why don't you move that logic into
ether_demux from the ether_input path, or have Netgraph use the
ether_input path?