ng_ether and vlan interfaces

Nikolay Denev ndenev at gmail.com
Tue Feb 15 14:02:30 UTC 2011


Hi,

When trying to use ng_ether with vlan interfaces using the naming sheme ${parent_if}.${vlan_tag}
it produces the following warning :

    ng_ether_attach: can't name node ix0.512

And the newly created netgraph node stays <unnamed>.

This is due to the following check in sys/netgraph/ng_base.c:ng_name_node() :

        /* Check the name is valid */
        for (i = 0; i < NG_NODESIZ; i++) {
                if (name[i] == '\0' || name[i] == '.' || name[i] == ':')
                        break;
        }

Do we really do not want to allow dot in the name?
If it's not an option to allow the dot, probably it would be better to replace it with
underscore.

I can provide a patch if the change is acceptable.

Cheers,
Nikolay


More information about the freebsd-net mailing list