kern/141646: [em] em(4) + lagg(4) + vlan(4) generatesISL-tagged frames instead of 802.1q-tagged frames

[Vitaliy Ovsyannikov]

> ----- Original Message -----
> Since your using lagg there Jeff have you done on perf testing at
> all, when I tested here dual em0 + lagg + lacp => cisco 6509 although
> all seemed to negotiate correctly, balancing wasn't working at all.

> So I'm wondering if you see the same behaviour or if its just me?

Balancing  depends  on  src/dst mac/ip. E.g. packets between different
IPs  are going thru different interfaces. It seems you are using iperf
to generate traffic flow between IP1 and IP2 so this is wrong case.

I've successfully patched 8.0-REL and it looks very happy with dot1q
vlans on lagg. Here are my results based on regular Internet traffic.

Env:
FreeBSD agw3.local 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #1:
Tue Mar  9 09:53:53 KRAT 2010     root at local:/usr/obj/usr/src/sys/KERNEL  i386

There are some vlans on lagg0:
#ifconfig | grep vlan | grep lagg0 | wc -l
      52

lagg0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=9b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM>
        ether 00:11:0a:5a:5e:5a
        media: Ethernet autoselect
        status: active
        laggproto lacp
        laggport: em3 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>
        laggport: em2 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>
        laggport: em1 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>
        laggport: em0 flags=1c<ACTIVE,COLLECTING,DISTRIBUTING>

agw3# netstat -I lagg0 -w1
            input        (lagg0)           output
   packets  errs      bytes    packets  errs      bytes colls
     24395     0   18251427      24390     0   18340400     0
     37221     0   29695929      37091     0   29594257     0

agw3# netstat -I em0 -w1
            input          (em0)           output
   packets  errs      bytes    packets  errs      bytes colls
      3432     0    1999523       5768     0    5191905     0
      4381     0    2746333       6874     0    5656798     0

agw3# netstat -I em1 -w1
            input          (em1)           output
   packets  errs      bytes    packets  errs      bytes colls
      7101     0    5874769       9932     0    8027032     0
      7815     0    6604168       9525     0    7590696     0

agw3# netstat -I em2 -w1
            input          (em2)           output
   packets  errs      bytes    packets  errs      bytes colls
      7857     0    6213003       7230     0    4975652     0
      9461     0    7349928       7758     0    5474243     0

agw3# netstat -I em3 -w1
            input          (em3)           output
   packets  errs      bytes    packets  errs      bytes colls
      7505     0    6013276       9584     0    7213921     0
      7571     0    5920826      10285     0    7205087     0