Why lagg(4) wants ~IFF_DRV_OACTIVE?

[Xin LI]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi, David,

On 2010/03/08 12:03, David Horn wrote:
> On Mon, Mar 8, 2010 at 2:32 PM, Andrew Thompson <thompsa at freebsd.org> wrote:
>> On Mon, Mar 08, 2010 at 11:12:25AM -0800, Xin LI wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi,
>>>
>>> Maybe this is a stupid question but I really don't understand why a
>>> interface with IFF_DRV_OACTIVE can't be added to a lagg(4) interface.
>>> Looking at OpenBSD code, they do this since the day 0.
>>>
>>> Could anyone shed some light, why we need to enforce this check? :)
>>
>> I think it was just carried over, I dont see any reason to keep it.
> 
> That's good news.
> 
> Someone,  please review and commit attached patch for
> sys/net/if_lagg.c.  This also fixes my PR:  kern/139117.

This is exactly the patch I'm talking about so I committed against
- -HEAD.  Will MFC after 1 month so we can see if there would be some
concerns or objections from others.

For kern/139117, this change MAY have made the problem to disappear but
I'm not convinced that the real bug has been fixed, though...

Cheers,
- -- 
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBAgAGBQJLlZxyAAoJEATO+BI/yjfB86wH/ixeSSUoIXRmja8Ujzwg9Xdw
0qeaGQZIVtYfpnVHUZ/oQ52fo9OoingogKruT8iN8oVECht90Jac5+O6xQoS1CPr
G/smeZJqG/n17WTshe7Oid/D8LfiABsA+drfY57gDx4YPrKX3NRApRwRFjLcRO97
S0K7XJpItDyQ8YZVxwVJa0B3R3kC6tGxCaQ8YL4VWYa/sHrgxbmeo7RWgLUJ51oP
H4NVNllk3grjln2Kv0DJHhvAkVfQocHFCJvQJ8sNGSdLjfVqr//RBHY0QhfviyfQ
McfiGkA9QAG8A09wWjUTF+8dEs5jzCk0CdUhbEEhRFByuBskwAeyX+Ak0BYflLw=
=oTzy
-----END PGP SIGNATURE-----