kern/142018: [iwi] [patch] Possibly wrong interpretation of beacon-> number in if_iwi.c

[Bernhard Schmidt]

The following reply was made to PR kern/142018; it has been noted by GNATS.

From: Bernhard Schmidt <bschmidt at techwires.net>
To: bug-followup at freebsd.org, Andre.Albsmeier at siemens.com
Cc:  
Subject: Re: kern/142018: [iwi] [patch] Possibly wrong interpretation of beacon-&gt;number in if_iwi.c
Date: Thu, 14 Jan 2010 16:10:28 +0100

 Hi,
 
 It might be simple endianess related issue, does this patch make any 
 difference?
 
 Index: if_iwi.c
 ===================================================================
 --- sys/dev/iwi/if_iwi.c	(revision 202285)
 +++ sys/dev/iwi/if_iwi.c	(working copy)
 @@ -1499,9 +1499,9 @@ iwi_notification_intr(struct iwi_softc *sc, struct
  		beacon = (struct iwi_notif_beacon_state *)(notif + 1);
  
  		DPRINTFN(5, ("Beacon state (%u, %u)\n",
 -		    beacon->state, le32toh(beacon->number)));
 +		    le32toh(beacon->state), le32toh(beacon->number)));
  
 -		if (beacon->state == IWI_BEACON_MISS) {
 +		if (le32toh(beacon->state) == IWI_BEACON_MISS) {
  			/*
  			 * The firmware notifies us of every beacon miss
  			 * so we need to track the count against the
 
 -- 
 Bernhard