funny ECMP

[Li, Qing]

Hi,

> 
> I have changed the route selection code of ecmp to
> balance only between routes of the same weight.
> (see attached file)
> 


>
> As Qing Li mentioned months ago, there are problems with static routes
> and interfaces.
> 

  Do you have the exact link to the email thread? 
  There were no pending ECMP related issues since my last round of
commits
  as far as I can remember.

>
> Example 1:
> ifconfig em1 alias 10.13.13.90/24
>  	ping 10.13.13.95 ok
> route add 10.13.13.0/24 10.11.11.1 -weight 2
>  	ping 10.13.13.95 broken (arpresolve: can't allocate llinfo for
>  				10.13.13.95)
> 

  Could you please explain a bit on exactly what you try to 
  accomplish here with this configuration?

> 
> deleting the last static multipath routes seems to affect?, destroy?
> the interface route.
> system crashes in:
> /usr/src/sys/net/route.c:370
>          rn = rnh->rnh_matchaddr(dst, rnh);
>          if (rn && ((rn->rn_flags & RNF_ROOT) == 0)) {
>                  newrt = rt = RNTORT(rn);
> here ->         RT_LOCK(newrt);
>                  RT_ADDREF(newrt);
>                  if (needlock)
> 

  I will take a look.

  -- Qing