Ethernet NIC drivers depending unconditionally on INET

[Bjoern A. Zeeb]

On Fri, 12 Jun 2009, Andrew Gallatin wrote:

> Bjoern A. Zeeb wrote:
>> On Fri, 12 Jun 2009, Navdeep Parhar wrote:
>> 
>>> On Fri, Jun 12, 2009 at 10:56:31AM +0000, Bjoern A. Zeeb wrote:
>>>> On Fri, 12 Jun 2009, Pyun YongHyeon wrote:
>>>> 
>>>> Hi,
>>>> 
>>>>> Yeah, there are no checksum offloading support for IPv6 under
>>>>> FreeBSD so there are no cases the frames are IPv6 when
>>>>> CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set.
>>>> 
>>>> The thing that scared me was sys/netinet/tcp_subr.c:tcp_maxmtu6().
>>>> 
>>>> What I had missed was the CSUM_TSO6  (the 6 at the end) part.
>>>> grepping through the tree I am even wondering a lot more now when I
>>>> see what cxgb(4) is doing with that;)
>>> 
>>> I can't find a CSUM_TSO6 in head, did you mean IFCAP_TSO6?
>> 
>> yes I did.
>> 
>>> cxgb(4)
>>> will not let you enable IFCAP_TSO6 on the interface.  It has always
>>> been disallowed as far as I can tell.
>> 
>> Yes, you have it in the logic bu you define it to 0;)
>>     #define IFCAP_TSO6 0x0
>
> So I guess TSO6 has never been tested at all on any interface on
> Freebsd.  Is this true?

I wan't not sure; looking at em_tso_setup() in sys/dev/e1000/if_em.c,
there was v6 code as well; the I spotted the return FALSE;

So I guess, you are right; noone ever did TSO6 on FreeBSD probably.

/bz

-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.