Problem with IFDATA_DRIVERNAME sysctl

Bruce M. Simpson bms at FreeBSD.org
Wed Sep 10 12:23:43 UTC 2008


Brooks Davis wrote:
>
>> --- if_mib.c.orig	2008-09-10 00:31:25.000000000 +0100
>> +++ if_mib.c	2008-09-10 00:32:15.000000000 +0100
>> @@ -90,6 +90,7 @@
>>  	switch(name[1]) {
>>  	default:
>>  		return ENOENT;
>> +		break;
>>     
>
> That's clearly a no-op since it's unreachable.
>
>   
>>  	case IFDATA_GENERAL:
>>  		bzero(&ifmd, sizeof(ifmd));
>> @@ -136,6 +137,7 @@
>>  		error = SYSCTL_IN(req, ifp->if_linkmib, ifp->if_linkmiblen);
>>  		if (error)
>>  			return error;
>> +		break;
>>     
>
> This looks OK, but I haven't checked the context.
>   

It looks like an unintentional fall-through to case IFDATA_DRIVERNAME, 
so I'll commit that part.



More information about the freebsd-net mailing list