[ipsec] KEY_FREESAV() in FreeBSD-Release7.0

[blue]

Dear all:

About the KEY_FREESAV() in key_checkrequest() in key.c:

line 806:
    if (isr->sav != NULL) {
       KEY_FREESAV(&isr->sav);
       isr->sav = NULL;
    }

The codes are only going to free the sav used LAST TIME. For outgoing SA 
entries, the reference count will be always 2, instead of 1 like 
incoming SA. I thought the proper place to call KEY_FREESAV() should be 
ipsec6_output_trans() and ipsec6_output_tunnel() after invoking each 
transform's output function. Then the SA will be freed after its usage 
rather than being freed if there's next IPsec packet.

If the above condition is accpeted, then key_delsp() in key.c should not 
call KEY_FREESAV() in case SA reference count underflow!

BR,
blue