Thoughts on vlan filter

[Scott Long]

Jack Vogel wrote:
> I had an idea, I was debugging a problem on my new 10G driver a week back,
> and found I had the hardware vlan filter enabled by accident, this led me to
> wonder about supporting this hardware feature in the driver...
> 
> I have done some experimentation, and find that when the vlan device is
> configured, ultimately the SETMULTI ioctl will happen in my driver, this
> means I could add code that checks the trunk, finds there is a vlan and
> then sets the tag into the filter.
> 
> Any interest, or thoughts ya or nay about my doing this?
> 
> Cheers,
> 
> Jack

Overloading the SETMULTI ioctl is probably a bad idea for anything more
than a proof-of-concept.  From a cleanliness point of view, making the
software vlan module aware of this as a hardware offload capability and
able to control it via new ioctls sounds more reasonable.

Scott