[PATCH] Ethernet cleanup; 802.1p input and M_PROMISC

Bruce M Simpson bms at incunabulum.net
Tue Mar 6 16:06:01 UTC 2007


Julian Elischer wrote:
>
> When we added netgraph we split both the input and output parts
> so that they would provide 'natural' entrypoints for a bridge.
> Consider where a bridge wants to put packets.
In bms_netdev, bridge_input() is entered directly from ether_input(). It 
may potentially re-enter, so M_PROMISC is cleared on frames thus handed 
off to if_bridge(4). Same for ng_ether(4).
>
> Since the split however other code has made use of those entrypoints 
> at different
> times. I'm not sure at the moment whether other code does so now. 
According to KScope on -CURRENT, the only other places which call the 
split ether_demux() are dummynet_send() and ng_ether_rcv_upper().

Regards,
BMS


More information about the freebsd-net mailing list