iwi leaks memory?

[Max Laier]

On Saturday 17 February 2007 14:27, V.Chukharev wrote:
> On Fri, 16 Feb 2007 23:10:24 +0200, V.Chukharev <chukharev at mail.ru> 
wrote:
> > On Fri, 16 Feb 2007 19:43:17 +0200, Jeremie Le Hen 
<jeremie at le-hen.org> wrote:
> >> Hi,
> >>
> >> cognet@ has once provided me a tiny hack to the iwi(4) driver and
> >> I never get such errors.  Maybe I'm not suffering enough UP/DOWN
> >> cycles to trigger it, but it might be worth trying it.
> >>
> >> Note that he has insisted that this is a *hack*.
> >>
> >> The patch is attached.  Please let us know if it makes things
> >> better.
> >
> > I cannot apply the patch ;-(
> > It seems it's for CURRENT, and I run STABLE.
>
> I applyed the patch regenerated by Oliver against STABLE (I did not
> recieve the message, found it on the list archive, that's the reason
> for replying to myself).
>
> Yes, the patch helps. The driver did not complain after 100 down/up
> cycles. Before the patch, it started to complain usually after 6..8
> cycles.

Okay ... this confirms that this is a problem with memory fragmentation.  
It seems that keeping the DMA'able memory around is indeed the best thing 
we can do.  As long as the firmware is as (un)reliable as it is now there 
is no way around the casual reset.  For normal operation it seems best to 
store the bss firmware in the DMA'able memory and keep it there.  That 
lets us firmware_put() the image itself.  I will have a patch later 
today, unless somebody disagrees and/or has a better idea.

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20070217/1d220ed2/attachment.pgp