Zeroing wrong union member in in6_control()

gnn at FreeBSD.org gnn at FreeBSD.org
Tue Feb 7 21:56:04 PST 2006


At Tue, 07 Feb 2006 11:38:09 -0500,
James Juran wrote:
> 
> [1  <text/plain (quoted-printable)>]
> In what looks like a copy&paste remnant from the preceding case, the
> wrong union member is used as the first argument to bzero in
> in6_control().  This doesn't cause an actual bug, but making this change
> would improve code clarity and robustness to change and also avoids a
> warning from a certain static analysis tool.
> 
> I'm not a regular FreeBSD contributor, so if this patch is worthwhile
> can someone please apply it?  If I should send things like this to a
> different mailing list in the future, please let me know.

The Kame list is still the best one for this (kame
<snap-users at kame.net>) but I've forwarded it for you.

I'll take care of getting this into FreeBSD though.

Thanks,
George


More information about the freebsd-net mailing list