if_bridge.ko requires INET6...

[Luigi Rizzo]

On Thu, Feb 02, 2006 at 01:49:40AM +0300, Yar Tikhiy wrote:
> On Wed, Feb 01, 2006 at 12:37:46PM +0200, Ruslan Ermilov wrote:
> > On Wed, Feb 01, 2006 at 06:41:10PM +0900, Hajimu UMEMOTO wrote:
> > > >>>>> On Wed, 1 Feb 2006 12:04:21 +0300
> > > >>>>> Gleb Smirnoff <glebius at FreeBSD.org> said:
> > > 
> > > glebius> If you have compiled the modules as part of buildkernel
> > > glebius> target, then all options from kernel would apply to all
> > > glebius> modules, thus the bridge_ip6_checkbasic() function won't
> > > glebius> be present in if_bridge.ko, and you would successfully
> > > glebius> load the module.
> > > 
> > > I believe it is 7-CURRENT thing, and is not MFCed yet.  So, if it is
> > > on 6.x, you need -DNO_INET6 to build if_bridge.ko.
> > > 
> > Ask yar@ to MFC his modules/ mega-commit that fixed this in HEAD.
> > I'd really love to see it in 6.1.
> 
> I haven't considered that an option since two issues were found
> related to my mega-commit.  One was that if_gif wouln't load due
> to unresolved symbols if built w/o INET6.  The other was in the
> pf module -- pflog would be lost as it didn't have a separate module.
> 
> The essence of the first issue is that the set of source files
> for a module cannot depend on kernel options, unlike for the main
> kernel file.
> The second issue has to do with the fact that pflog is more to
> a plain option than to a device, as there are `#ifdef DEV_PFLOG'
> lines in the pf code conditionalizing the pflog feature.

can you give more details on the if_gif issue ? lookint at the
code in if_gif.c it seems that compiling it with INET6 does not define any new
symbols but only adds some code paths within existing functions, so
i don't exactly understand why the load failure.

cheers
luigi

> -- 
> Yar